Do not import PETSc at the top-level - #5
Merged
Conversation
This avoids us initialising PETSc before petsctools.init is called.
Member
class OptionsManager
@classmethod
def _get_commandline_options(cls):
from petsc4py import PETSc
return frozenset(PETSc.Options().getAll())
@property # or @cachedproperty
def commandline_options(self):
return self._get_commandline_options() |
Collaborator
Author
|
dham
approved these changes
Jun 25, 2025
This was referenced Jun 30, 2025
JHopeCollins
requested changes
Jul 1, 2025
JHopeCollins
approved these changes
Jul 2, 2025
JHopeCollins
left a comment
Member
There was a problem hiding this comment.
Seems to DTRT again now for command line arguments. Happy for this to be merged once the linting is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids us initialising PETSc before petsctools.init is called.
Note that this does result in a small API change. We now have
OptionsManager.get_commandline_options()instead ofOptionsManager.commandline_options. I don't know a better way to do this.